hlxsites / vg-macktrucks-com

Franklin site for https://www.macktrucks.com
Apache License 2.0
1 stars 27 forks source link

v5 aem.js loadCSS returns a promise #782

Closed jonatan-lledo-netcentric closed 21 hours ago

jonatan-lledo-netcentric commented 4 days ago

Bug Fix

The new helix v5 has changed how the function loadCSS works. Now is returning a promise. So it's no longer necessary to enclose the function into a promise or wait if it's applied.

Test instrucctions

The "After" branch is based on main branch, so that's why the "Before" is the spike's one. play a bit first in the spike and copy this solution into there to test it

#

Fix #752

Test URLs:

Also for testimonial video modals

aem-code-sync[bot] commented 4 days ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [cabfef1](https://github.com/hlxsites/vg-macktrucks-com/commit/cabfef1fca466023309c14a350cf7d32619b889e) :white_check_mark: (latest) * [7c05a02](https://github.com/hlxsites/vg-macktrucks-com/commit/7c05a02e62aab643d6cebf6f46e8a1a97d09f87b) :white_check_mark: * [edf7750](https://github.com/hlxsites/vg-macktrucks-com/commit/edf7750227b8616f88b13111ba5a2e9efbdbf021) :white_check_mark:
aem-code-sync[bot] commented 4 days ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/drafts/syb/block/v2-testimonial-video PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI