hlxsites / vg-roadchoice-com

Road Choice website
https://www.roadchoice.com
Apache License 2.0
1 stars 0 forks source link

FR: [Specifications] - Reuse Mack V2 block for Road Choice #235

Closed ZoeBeykirch closed 1 month ago

ZoeBeykirch commented 4 months ago

Context/Description

As a Road Choice content author, I want to reuse the V2 block from Mack Trucks so that the Road Choice brand website can display safety data sheets in a more user friendly and visually appealing way to match Mack's improved digital experience. This will be a combination of the v2 accordion and v2 specifications.

Acceptance Criteria

User AC:

Editor AC:

Non-functional AC:

Attachment / link to Figma

Although there is no Figma designs for this, use the Volvo website as a reference for how the block should look and function: https://www.volvotrucks.us/parts-and-services/parts/material-safety-data-sheets/

There is a block for this on Mack Trucks to see a reference for other websites, but the Volvo styling is more in line with the desired outcome: https://www.macktrucks.com/parts-and-services/parts/mack-parts/material-safety-data-sheets

girishdigrajkar commented 2 months ago

Desktop & Tablet viewport : No issues

Mobile:

  1. Mobile view looks bit odd as have cosmetic issues related to texts and extra indentations : Pasted Graphic

Observations/Queries:

  1. Unlike Volvotrucks & Macktrucks,sites, + / - signs are not used for collapse/expand mode instead up and down arrows are used is it; Is it specific for road choice ?
  2. Errors are displayed ; Cookies like errors could be ignored as its branch url however, worth checking for other errors:
EXHAUST
santi-homps commented 2 months ago

@girishdigrajkar already fixed the mobile issues. Regarding the other comments: 1- It was based on the accordion set in here 2- I'm not getting these errors. Could you maybe clean the cache and re-check?

girishdigrajkar commented 2 months ago

Validated and able to get the correct results now and hence, ticket could be closed:
@santi-homps : Please proceed for PR merge and marking it to 'Ready for prod'

image