hlxsites / vg-roadchoice-com

https://www.roadchoice.com
Apache License 2.0
0 stars 1 forks source link

FR: [Columns] - Roadchoice Block #236

Open ZoeBeykirch opened 2 months ago

ZoeBeykirch commented 2 months ago

Context/Description

As a Road Choice content author, I want to have a columns block on my website so that I can alternate images and text on within the same page seamlessly so that I can improve the user experience.

Acceptance Criteria

User AC:

Editor AC:

Non-functional AC:

Attachment / link to Figma

Examples: https://www.volvotrucks.us/parts-and-services/parts/partsasist/ https://www.volvotrucks.us/trucks/powertrain/i-torque/

Image

girishdigrajkar commented 1 month ago

Observation :

  1. Sequence of image/text is incorrect in case of mobile viewport: If image is on left and text on right then on mobile viewport. image comes first and then text Whereas, when image is on right and text on left then, on mobile viewport text is displayed first followed by image ... It happens correctly in case of reference URL mentioned in ticket https://www.volvotrucks.us/parts-and-services/parts/partsasist/

however, on https://236-columns--vg-roadchoice-com--hlxsites.hlx.page/drafts/shomps/media-with-text the sequence is image first and text later which is not in sync with whats mentioned as expectation in User story

  1. top margin is not available in the block, it should be 48px.
BeckyMedlin commented 4 weeks ago

@santi-homps Is this item still blocked?

girishdigrajkar commented 3 weeks ago

@santi-homps : This PR is already merged with open observation so it should be fixed immidiately:

image image
santi-homps commented 3 weeks ago

@girishdigrajkar Post discussion with @ZoeBeykirch this issue can be closed since this behaviour is as expected.