hlxsites / vg-volvotrucks-ca

Franklin site for Volvo Trucks Canada
https://www.volvotrucks.ca/
Apache License 2.0
0 stars 0 forks source link

Publish all redesign blocks, header, footer, etc from USA repo to Canadian repo #50

Closed ZoeBeykirch closed 5 months ago

ZoeBeykirch commented 7 months ago

Agile requirement: The user experience on the Volvo Trucks Canadian (English and French language) should be seamless in matching the newly redesigned on-brand experience as the USA site.

Acceptance criteria:

shirin27 commented 7 months ago

Requirement:

NOTE: To be discussed by @cogniSyb and Adobe for a final solution design, and then refined with the team.

cogniSyb commented 6 months ago

Development is being done in https://github.com/hlxsites/vg-volvotrucks-us/issues/530.

Right now I’m testing some pages.

BeckyMedlin commented 6 months ago

@cogniSyb For the French header/footer, I think this ticket is related: https://github.com/hlxsites/vg-macktrucks-ca/issues/22 (it's for all markets, not just Mack).

cogniSyb commented 6 months ago

Good catch @BeckyMedlin. As the content is hardcoded, I’d like to receive a translation of the 404 content as well. It’ll be an easy fix :)

cogniSyb commented 6 months ago

Question related to Pardot

ryanropero commented 6 months ago

@cogniSyb we can do this two ways 1) We add an additional field for Form Name and you can populates it with "Newsletter US" " Newsletter CA-EN" or " Newsletter CA-FR" or something like that. 2) We have 3 separate forms and I can identify what site it is from.

cogniSyb commented 6 months ago

@ryanropero thanks, I’ll add a hidden form field and will make changes for some text that is currently hardcoded.

Seems like a better idea to have separate forms per country, but if you can filter it in this way, then it’s less work for development :)

Joesturbo commented 6 months ago

@BeckyMedlin - can we add to SRB?

@cogniSyb - would it make better sense to create a separate repo for Canada French vs. trying to fix all of the issues here? Thinking out loud to be more efficient.

Kannan-CM commented 6 months ago

Hi @cogniSyb ,

The content task is completed

BeckyMedlin commented 6 months ago

@cogniSyb @shirin27 @mollyaljenkins @Kannan-CM completed the content tasks requested for this ticket. Syb can proceed with the dev work.

girishdigrajkar commented 6 months ago

Observed content issues for en-ca : #53 & for fr-ca #54 Except for these we can proceed with this ticket.