Closed dylandepass closed 1 year ago
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.
Page | Scores | Audits | |
---|---|---|---|
/ | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/ | Lighthouse returned error: Something went wrong. | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/ | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/ | ![]() |
Page | Scores | Audits | |
---|---|---|---|
/ | ![]() |
Do not merge until https://github.com/adobe/helix-website/pull/275 is merged
This PR migrates the
volvotrucks-us
site to the new full screen version of the sidekick library.@synox Most blocks worked without change, some required changes due to
window.location.origin
not existing when running in the sidekick library.Two blocks need to be slightly reworked.
These blocks assume the content to feed them is in the same place as the page itself. It doesn't look like this pattern is going to work. I would suggest to rework these blocks to instead configure them using block config and read in the values using the
readBlockConfig
method fromlib-franklin
.Test URLs: