hlxsites / vg-volvotrucks-us

Franklin site for https://www.volvotrucks.us/
https://www.volvotrucks.us/
Apache License 2.0
2 stars 6 forks source link

Bug: Major: Volvotrucks : "fbevents.js" triggers although the user has turned off Social media cookies #457

Closed girishdigrajkar closed 10 months ago

girishdigrajkar commented 1 year ago

Steps:

  1. Navigate to https://www.volvotrucks.us/
  2. Turn off "Social Media Cookies"
  3. Validate the Network tab in developer options

Expected vs Actual: "fbevents.js" triggers although the user has turned off Social media cookies image

girishdigrajkar commented 12 months ago

Validated and failed for the case when user selects 'social media cookies' and later on disables them. hence, reopening the defect.

When accepted Social Media cookies: image

When accepted social media cookies initially and rejected later : fbevents.js should not be triggered post the social media cookie is rejected. image

Bydefault, when site is opened : image

girishdigrajkar commented 10 months ago

Validated and able to see the fbevents.js in case user turns on only performance cookies too thus, reopening the bug.

jonatan-lledo-netcentric commented 10 months ago

@Kannan-CM @Varunvolvo fbevents script is loaded twice, one when performance cookies are accepted because GTM loads it, and the other is when the social media cookies are accepted because the delayed.js from Franklin adds it, so I recommend removing the Pixel script from GTM and let be load only when social media cookies are accepted IMHO, WDYT?

Gonzalo-CG commented 9 months ago

If performance & social media are accepted --> pixel script should only be injected by GTM. If performance is not allowed & social media is allowed--> pixel script is injected by delayed.js

DanielaPedrochevd commented 9 months ago

linked to #489

girishdigrajkar commented 9 months ago

Retest Failed :

image
jonatan-lledo-netcentric commented 9 months ago

if performance is accepted but not Social media -> GTM loads anyway fbevents and I tried to removed it, so. what can we do then

manuel-vara commented 9 months ago

IMO, it needs to be removed from GTM console. @Kannan-CM , is that possible?

Kannan-CM commented 9 months ago

I have removed the Facebook pixel from Firing through Google Tag Manager. Please validate and let me know if it looks okay on your end

DanielaPedrochevd commented 9 months ago

Spillover because we needed to raise a new PR since we will have to remove the check, this will be reviewed but it means it will be a spillover.

girishdigrajkar commented 8 months ago

Validated and able to get the below correct results and hence, this ticket could be marked to done status:

If Social media cookie is turned ON >> Fbevents.js should be available in Network tab irrespective of status of other cookies

image

If Social media cookie is turned OFF >> Fbevents.js should NOT be available in Network tab irrespective of status of other cookies

image image