hlxsites / vg-volvotrucks-us

Franklin site for https://www.volvotrucks.us/
https://www.volvotrucks.us/
Apache License 2.0
2 stars 5 forks source link

FR: Powertrain performance graph and specs adapted to work with new re-design style #519

Open ZoeBeykirch opened 5 months ago

ZoeBeykirch commented 5 months ago

Agile requirement: As a content editor, I want to use the newly re-designed blocks on the powertrain pages without it impacting the design of the current performance specifications engine graphs that are published on the website.

Description: With the current solution, when a content editor adds any redesign block to the current Powertrain web pages, the engine performance graphs and engine specifications sections are negatively impacted distorting the UX, as seen in this example and screen shot below.

To improve the user experience, the engine specs and graph design should be adjusted to fit in harmony with the newly redesigned blocks which require the new redesign metadata style applied to the entire web page. image

Acceptance Criteria:

image

Out of scope

Note

Enhancement of Mobile Experience:

cogniSyb commented 5 months ago

My findings on the page

My findings on the block

cogniSyb commented 4 months ago

Another observation: the graph is not rendering correctly on Firefox: Screenshot 2024-02-13 at 13-41-07 Volvo D11 Volvo Trucks USA

This is due to the fact that we have a path output containing commas. Changing return plotedLine; to return plotedLine.join(' '); and fixing the viewBox will resolve this issue.

mollyaljenkins commented 4 months ago

@ZoeBeykirch @cogniSyb Can we discuss this issue further ?

ZoeBeykirch commented 4 months ago

@cogniSyb @mollyaljenkins Confirming yes, this solution is the desired state (which hopefully will decrease the current HL estimate for story points) - https://519-engine-specifications--vg-volvotrucks-us--hlxsites.hlx.page/trucks/powertrain/d11/new#performance-specifications

Joesturbo commented 1 month ago

@mollyaljenkins - can we review the amount of time on this item, reflection on the work completed with the Mack solution?

mollyaljenkins commented 1 week ago

Solution: https://519-engine-specifications--vg-volvotrucks-us--hlxsites.hlx.page/trucks/powertrain/d11/new#performance-specifications