Open cogniSyb opened 5 months ago
@shirin27 The milestones for this ticket are incorrect.
@BeckyMedlin added the Volvo Refactoring milestone, I think this would be the right one.
@cogniSyb Should all of this be done dynamically? Is there a possibility of dynamic updates causing an issue? We can discuss in refinement if needed.
Sometimes placeholders are missing or removed. This needs to be flagged. Some placeholders aren’t in use. We need to remove them.
A new function was added,
getPlaceholders
in https://github.com/hlxsites/vg-volvotrucks-us/commit/50d802b1493017e003c005e06ce707847c2fe0df and https://github.com/hlxsites/vg-macktrucks-com/commit/592f3e04b3a903eabecab5b0f012bf9f0adb2ed3.See https://projects.netcentric.biz/wiki/pages/viewpage.action?pageId=495752915#Frontendchangesinaem.js/helixv5-VTfetchPlaceholders as well
https://www.aem.live/developer/placeholders
Requirements
Remove unused placeholders
Create a test to make sure we don’t have missing items
Placeholders need to follow a naming structure
Refactor code and use standard AEM functionality
[ ] Define placeholder naming structure. Examples of inconsistencies: "recall_date", "READ NOW", "Search For", "no results", "event-notify:first-name"
[ ] Figure out how we should deal with multilingual solutions; AEM code is prepared for it, but