hlxsites / vg-volvotrucks-us

Franklin site for https://www.volvotrucks.us/
https://www.volvotrucks.us/
Apache License 2.0
2 stars 5 forks source link

Clean up and test placeholders #529

Open cogniSyb opened 5 months ago

cogniSyb commented 5 months ago

Sometimes placeholders are missing or removed. This needs to be flagged. Some placeholders aren’t in use. We need to remove them.

A new function was added, getPlaceholders in https://github.com/hlxsites/vg-volvotrucks-us/commit/50d802b1493017e003c005e06ce707847c2fe0df and https://github.com/hlxsites/vg-macktrucks-com/commit/592f3e04b3a903eabecab5b0f012bf9f0adb2ed3.

See https://projects.netcentric.biz/wiki/pages/viewpage.action?pageId=495752915#Frontendchangesinaem.js/helixv5-VTfetchPlaceholders as well

https://www.aem.live/developer/placeholders

Requirements

BeckyMedlin commented 4 months ago

@shirin27 The milestones for this ticket are incorrect.

shirin27 commented 4 months ago

@BeckyMedlin added the Volvo Refactoring milestone, I think this would be the right one.

BeckyMedlin commented 3 months ago

@cogniSyb Should all of this be done dynamically? Is there a possibility of dynamic updates causing an issue? We can discuss in refinement if needed.