hlxsites / vg-volvotrucks-us

Franklin site for https://www.volvotrucks.us/
https://www.volvotrucks.us/
Apache License 2.0
2 stars 5 forks source link

Configuration of language and search #530 #533

Closed cogniSyb closed 4 months ago

cogniSyb commented 4 months ago

Fix #530

Test URLs:

I went over the 64 diverging commits of https://github.com/hlxsites/vg-volvotrucks-ca and checked which changes we needed and which code was outdated.

Added two columns in metadata.xlsx: Locale and Disable search. The former will influence the lang attribute of the page and instances where we need locale to transform dates in JavaScript. The latter is a quick solution to disable the search functionality in the header on the whole site (or part of it).

As the NTHSA pages don’t follow the pattern I’d like to, and as they won’t be used for other markets, I kept that code as-is.

aem-code-sync[bot] commented 4 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [2f5d716](https://github.com/hlxsites/vg-volvotrucks-us/pull/533/commits/2f5d7168fcf627ef7d27ba20dcc7dbfb44c6e2a0) :white_check_mark: (latest) * [a39d9f2](https://github.com/hlxsites/vg-volvotrucks-us/pull/533/commits/a39d9f2fd012eee2cbb3b9a59fae917698848bba) :white_check_mark: * [8f7078a](https://github.com/hlxsites/vg-volvotrucks-us/pull/533/commits/8f7078a055ceb0d24ffc63ae7f3a312de19420af) :white_check_mark: * [a5f4cca](https://github.com/hlxsites/vg-volvotrucks-us/pull/533/commits/a5f4cca07698ba70d288775d04dd4d79013eedf2) :white_check_mark: * [ae051d7](https://github.com/hlxsites/vg-volvotrucks-us/pull/533/commits/ae051d77e39f3e73377071d743654f128afed4a9) :white_check_mark: * [82dcafa](https://github.com/hlxsites/vg-volvotrucks-us/pull/533/commits/82dcafaa29d3f35874c6431127a876c30eb391f6) :white_check_mark: * [52390c5](https://github.com/hlxsites/vg-volvotrucks-us/pull/533/commits/52390c5535ded73b891d2c5945d900e06cfa568e) :white_check_mark: * [edcfb46](https://github.com/hlxsites/vg-volvotrucks-us/pull/533/commits/edcfb46458fba2db664d5c65e675da6e25a144d3) :white_check_mark:
aem-code-sync[bot] commented 4 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI