search

hlxsites / vg-volvotrucks-us

Franklin site for https://www.volvotrucks.us/
https://www.volvotrucks.us/
Apache License 2.0
2 stars 5 forks source link

Interaction blocked after clicking faulty modal link #534

Closed cogniSyb closed 1 month ago

cogniSyb commented 4 months ago

Given the user is on a page with a link to a page that should load in a modal When the user clicks on that link and the URL returns in a 404/403/500 error Then the modal functionality doesn’t fail gracefully and blocks the user from interacting with the page

The inert attribute is added to elements of the page, even if we fail to load the modal content. This should be changed.

BeckyMedlin commented 4 months ago

@cogniSyb Does this bug impact all modals or specific one(s)?

cogniSyb commented 4 months ago

It does impact the modals that are loading another page/document. So that’s the VT PDP modals and the one opening the Digital Reveal video.

For the Canadian website pages I've fixed the 404 issues, though a mistake in the URL can occur easily by a content editor.

BeckyMedlin commented 1 month ago

Per @cogniSyb "VT#607 is ready for production. The fix for this is also fixing VT#534, which is part of the bug described in VT#607. As the issues are not entirely the same I’m adding VT#534 to the sprint so that it’ll be part of the upcoming release notes"