hlxsites / vg-volvotrucks-us

Franklin site for https://www.volvotrucks.us/
https://www.volvotrucks.us/
Apache License 2.0
2 stars 5 forks source link

Refactor buttons to follow OOTB behavior #549

Closed shirin27 closed 1 month ago

shirin27 commented 4 months ago

From vg-volvotrucks-us-rd created by Gonzalo-CG: Netcentric/vg-volvotrucks-us-rd#163

Business value

As a content author/editor, I want a clear and standardized way to choose the styling of buttons across all blocks and pages.

Description

The current implementation of blocks like Truck Carousel has button styling defined by the order buttons are placed, i.e. when there are 2 buttons one below the other, the 2nd one is treated as a secondary button.

This implementation needs to be changed to align with the OOTB Franklin behavior, where variations of buttons are defined by the emphasis of the text in the Word document (e.g. bold or italic).

Acceptance Criteria

Notes

Franklin OOTB Buttons docs

shirin27 commented 4 months ago

@Gonzalo-CG Are there any broken components that need to be addressed?

shirin27 commented 4 months ago

@BeckyMedlin there are no broken components, this change is just so our code aligns with the OOTB solution Adobe provides to differentiate button styles (as per their docs)

cogniSyb commented 1 month ago

Closing as this has been picked up in #625