hlxsites / vg-volvotrucks-us

Franklin site for https://www.volvotrucks.us/
https://www.volvotrucks.us/
Apache License 2.0
2 stars 5 forks source link

Spillover - FR: Article Hero #553

Closed shirin27 closed 3 weeks ago

shirin27 commented 4 months ago

Description

As a business owner, I want to be able to display content in a hero to my page so that its design is more dynamic so that users can more easily see the image, reading time, title, author, topic category filters, and creation date.

Acceptance Criteria

User AC:

Editor AC:

Non-functional AC:

Attachment / link to Figma

Desktop and Tablet: https://www.figma.com/file/c2jG1bOcvle2bCmZqgptyS/Magazine-C%26T?type=design&node-id=1571%3A19765&mode=dev image

Mobile: https://www.figma.com/file/c2jG1bOcvle2bCmZqgptyS/Magazine-C%26T?type=design&node-id=1602%3A25713&mode=dev image

Open question:

Related Tickets:

562

williebender commented 1 month ago

@ZoeBeykirch @BeckyMedlin

From C&T, image size/aspect ratio:

Desktop 813:698 px (1.16:1) Tablet 680:510px (4:3) Mobile 343:245px (7:5)

This component is a modified version of Single Media of Text Block 2 FYI.

girishdigrajkar commented 1 month ago

Validated and able to get the correct results except below : @jonatan-lledo-netcentric

  1. Creation date in figma has month in format of MMM e.g. Jan. Whereas, implemented is complete month name. e.g. January Figma has reading time with no space in between e.g. 10min read whereas, implemented is with a space e.g. 11 min read

    1. Intermittent issue: iPad 10 I.e. iOS ver 17 + Chrome has rectangular buttons - This issue is intermittently reproducible with Browser stack on iPhone too
  2. Author no tags >> It shows empty button

    1. Author more than 5 tags : e.g. 7 tags; It displays all the 7 tags as buttons however, since its author controlled to 5 so this point is author controlled. - No action needed
  3. Kindly add this block in sidekick library later

    1. Unable to locate ‘All topics’ bar in any of Magazine related tickets @mollyaljenkins : Please check.
girishdigrajkar commented 3 weeks ago

Post confirmation from dev as fixed, below is summary of retesting: 1 - As expected; Inline to figma design 2 - not observed now 3- Working as expected now; no empty tag button displayed when have 0 tags 4- expected behaviour as dev comments

Defect could be closed