Make loading of third party scripts configurable

hlxsites / vg-volvotrucks-us

Franklin site for https://www.volvotrucks.us/

https://www.volvotrucks.us/

Apache License 2.0

2 stars 5 forks source link

Make loading of third party scripts configurable #577

Closed cogniSyb closed 1 month ago

cogniSyb commented 4 months ago

Some markets don’t require the usage of Hotjar or FacebookPixel. The scripts shouldn’t be loaded if they’re not necessary.

Requirements

Update delayed.js and constants.js. Configuration on whether the third-party script needs to be loaded resides in constants.js
The file delayed.js will be the same in the three market repositories (for US/CA/MX) to ensure streamlined releases
VT CA shouldn’t have Hotjar enabled
VT MX shouldn’t have Hotjar or Facebook pixel enabled
Add domain to constants.js

This issue is an extension of #535

BeckyMedlin commented 4 months ago

@mollyaljenkins This ticket notes that https://github.com/hlxsites/vg-volvotrucks-ca/issues/50 is blocked. Please update the ticket so that it reflects the correct status. Thank you!

BeckyMedlin commented 4 months ago

Prioritized as 1 as it is blocking a priority 1 ticket https://github.com/hlxsites/vg-volvotrucks-ca/issues/50.

cogniSyb commented 3 months ago

Kamino cloned this issue to hlxsites/vg-macktrucks-com

girishdigrajkar commented 1 month ago

Validation partly completed as can see configuration done using sharepoint excel; Hotjar and facebook pixel could not be tested in lower environments due to limitation( cookie functionality blocked + OneTrust not setup).

Below approach is agreed with Syb:

Going ahead with this change to production in US night time. @cogniSyb
Testing will only be possible post go live due to point 1 with coordination with @cogniSyb as we will simulate US, CA, MX configurations using US. @cogniSyb & @girishdigrajkar
Once change is proven on production then @mollyaljenkins : MX,CA tickets + Post deployments task tickets needed

(Below approach to be confirmed with business by @mollyaljenkins )