hlxsites / vg-volvotrucks-us

Franklin site for https://www.volvotrucks.us/
https://www.volvotrucks.us/
Apache License 2.0
2 stars 5 forks source link

Adobe Video Embed Block Adaptions #579

Closed shirin27 closed 2 months ago

shirin27 commented 4 months ago

From vg-volvotrucks-us-rd created by DanielaPedrochevd: Netcentric/vg-volvotrucks-us-rd#327

Agile Requirement As a business owner, I want to be able to upload videos to my assets and display them easily on any page using the AEM Asset Manager.

Description Make the pertinent code changes to the embed block so that content editors can easily add it to any of our pages and adapt it to follow our Figma designs. If the media with text and video player modal block are affected by this requirement, perform the changes so that the design continues as it has already been implemented.

Acceptance Criteria

  1. As a content editor, I can add a video to any page using the embed block.
  2. As a content editor, I can select between any of the three variants for this block:
  1. As a content editor, when I use the Media with text block to display a video, this block follows the Figma design and specifications already implemented in ticket https://github.com/Netcentric/vg-volvotrucks-us-rd/issues/180
  2. As a content editor, when I add a video to the video player modal, the video is displayed following the Figma design and specifications already implemented https://github.com/Netcentric/vg-volvotrucks-us-rd/issues/76.
shirin27 commented 4 months ago

Dependancy with changes on Adobe side. Will need more effort this sprint.

shirin27 commented 4 months ago

@shirin27 What else is needed?

shirin27 commented 4 months ago

@BeckyMedlin I’ve gotten an update from Adobe on this, there’s more functionality available as of now. I’m waiting on a response/discussion about the following requirements:

For now, it seems that everything is in place for MT requirements. @shirin27 could you create a copy of this issue for Mack Trucks without the following text and subsequent acceptance criteria?

and adapt it to follow our Figma designs. If the media with text and video player modal block are affected by this requirement, perform the changes so that the design continues as it has already been implemented.

shirin27 commented 4 months ago

Still waiting on Adobe per discussion with @cogniSyb

shirin27 commented 3 months ago

Alignment with Syb and Adobe on custom controls on the video to be scheduled.

Short term solution:

mollyaljenkins commented 2 months ago

Closed as it will be picked up in #610