hlxsites / vg-volvotrucks-us

Franklin site for https://www.volvotrucks.us/
https://www.volvotrucks.us/
Apache License 2.0
2 stars 5 forks source link

Bug: Helix 5 Upgrade - Site-wide JavaScript Issues with Modal #607

Closed ZoeBeykirch closed 1 month ago

ZoeBeykirch commented 2 months ago

Issue Type

Bug

Summary

[modal] JavaScript Issues

Priority

Blocker

Description

We have found multiple JavaScript related issues on the site that are likely caused by the conversion to Helix v5 and code upgrade:

Modals + videos don't open, and if a user tries to click on a modal afterwards all functions on the page fail. I.e. the user has to refresh the browser and no navigation item work as expected.

Affected Device Classes

Desktop, Tablet, Mobile

Affected Browsers/Devices and Versions

Chrome, Edge, and Safari were tested on desktop computer and iPhone. Likely issues extend to all browsers and devices.

Steps to Reproduce

  1. Navigate to https://www.volvotrucks.us/trucks/all-new-vnl/#resources
  2. When a user clicks on any modal or video block that should enable the functionality to open a new modal secondary page, the modal does not open. For example, click on "+EXPLORE EXTERIOR"
  3. Additionally, after a user attempt to click on the modal, all functions on the page fail. For example, after clicking "+EXPLORE EXTERIOR", try to click on any navigation item or button the page - it will not work until the user refreshes their browser page.
  4. Another example is on Resources section when clicking any of the video thumbnails.
  5. Investigation is that a Javascript failure causes this issue.

image

ZoeBeykirch commented 2 months ago

These bugs are no longer on prod now that the Helix 5 upgrade was reverted, but when we do the upgrade, we should be aware of how to address these issues.

cogniSyb commented 2 months ago

Kamino cloned this issue to hlxsites/vg-volvotrucks-us

cogniSyb commented 2 months ago

I cloned this issue to separate the modal issues from the magazine/press releases issues.

girishdigrajkar commented 1 month ago

Validated and able to get the correct results: No JS error displayed ( Below screenshot has a warning which is developer helpful info however it is not an error as validated with dev(Syb) )

image