search

hlxsites / vg-volvotrucks-us

Franklin site for https://www.volvotrucks.us/
https://www.volvotrucks.us/
Apache License 2.0
2 stars 5 forks source link

Bug: Helix 5 Upgrade - Site-wide JavaScript Issues Magazine/Press Releases #614

Closed cogniSyb closed 1 month ago

cogniSyb commented 2 months ago

Seperated from #607:

Issue Type

Bug

Summary

[magazine] [press-releases] JavaScript Issues

Priority

Blocker

Description

We have found multiple JavaScript related issues on the site that are likely caused by the conversion to Helix v5 and code upgrade:

PR and Magazine articles do not display properly.

Affected Device Classes

Desktop, Tablet, Mobile

Affected Browsers/Devices and Versions

Chrome, Edge, and Safari were tested on desktop computer and iPhone. Likely issues extend to all browsers and devices.

Steps to Reproduce

  1. Navigate to https://www.volvotrucks.us/
  2. Click on "News & Stories" in the main navigation
  3. Click on Magazine or Press Releases
  4. Then click on any magazine article or press release article. (Example of magazine + press release)
  5. When viewing a Magazine article, only the article title, image, author and date are visible. The body of the article content, navigation, and sub-navigation text is no longer displayed properly.
  6. When viewing a Press Release article, no text at all displays properly.
  7. Upon investigating the code, the display is set to "none" in the highlighted screenshot

Image Image Image Image

cogniSyb commented 2 months ago

These bugs are no longer on prod now that the Helix 5 upgrade was reverted, but when we do the upgrade, we should be aware of how to address these issues.

girishdigrajkar commented 1 month ago

@cogniSyb As discussed, https://helix-v5--vg-volvotrucks-us--hlxsites.aem.page/news-and-stories/volvo-trucks-magazine/ has issue related to sub header that, it does not go to top of screen hence, marking it to "in dev" status:

image