search

hlxsites / vg-volvotrucks-us

Franklin site for https://www.volvotrucks.us/
https://www.volvotrucks.us/
Apache License 2.0
2 stars 5 forks source link

Bug: Replace Font Awesome icons in Magazine #617

Closed cogniSyb closed 1 month ago

cogniSyb commented 2 months ago

Summary

[magazine-template] replace Font Awesome icons

Priority

Medium

Description

To support the helix-v5 upgrade, we will need to phase out support for Font Awesome icons in the decorateIcons script.

Only magazine.js uses Font Awesome icons in a way that depends on the decorateIcons script. The current implementation of these icons can be replaced to maintain the Font Awesome icons. The HTML output will become different.

As the Magazine will be part of redesign efforts, the icons will be replaced when new blocks will be built. Hence there’s no need to find alternative icons.

Value creation

Maintainability & scalability

Cost of fixing

Low cost

Technical complexity

XS

References

See also #616. This issue is to support https://github.com/hlxsites/vg-volvotrucks-us/pull/604

girishdigrajkar commented 1 month ago

Validated and able to get the correct results and hence, closing the issue :

image