hlxsites / vg-volvotrucks-us

Franklin site for https://www.volvotrucks.us/
https://www.volvotrucks.us/
Apache License 2.0
2 stars 5 forks source link

NFR: add custom decorateIcons script for helix v5 #621

Closed cogniSyb closed 1 month ago

cogniSyb commented 2 months ago

Context/Description

In PR #604 we noticed issues with icons. This is reported in #608. After investigation, we concluded that moving to the current version of the decorateIcons script of aem.js is impossible.

Our need of adapting icons to their context is of high importance. Migrating to another technique would mean:

Hence, it has been decided to move to one generic script for Mack Trucks and Volvo Trucks and use that instead of the function in aem.js

Acceptance Criteria

Editor AC:

Non-functional AC:

Out of scope

No response

Note

Due to the MT script for loading icons is more efficient, overall performance will be improved. It might be that this change will have a positive impact on #600

Technical details

Copy the code of https://github.com/hlxsites/vg-macktrucks-com/issues/700

Attachment / link to Figma

No response

cogniSyb commented 2 months ago

Kamino cloned this issue to hlxsites/vg-macktrucks-com