hlxsites / vg-volvotrucks-us

Franklin site for https://www.volvotrucks.us/
https://www.volvotrucks.us/
Apache License 2.0
2 stars 5 forks source link

Helix 5 Upgrade - Site-wide JavaScript Issues Magazine/Press Releases #614 #628

Closed cogniSyb closed 1 month ago

cogniSyb commented 1 month ago

Fix #614

Test URLs:

aem-code-sync[bot] commented 1 month ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [c02550a](https://github.com/hlxsites/vg-volvotrucks-us/commit/c02550a990a0c118880b37e170c2786899c647c8) :white_check_mark: (latest) * [dbcf0ec](https://github.com/hlxsites/vg-volvotrucks-us/commit/dbcf0ecdb473f38675cca753428782d77587da20) :white_check_mark:
amglebihan commented 1 month ago

@cogniSyb I don't know if it's related, but the sub-nav doesn't stick to the the correct position now.

subnav
cogniSyb commented 1 month ago

@cogniSyb I don't know if it's related, but the sub-nav doesn't stick to the the correct position now.

subnav

Thanks @amglebihan I'll look into it

cogniSyb commented 1 month ago

@amglebihan the change in aem.js is loading the header with header.append(headerBlock); instead of current header.prepend(headerBlock);. On top of that, the subnavigation is loaded earlier than the header, which doesn’t make sense as it’s part of the header. Yet it does, because it’s an autoblock. We’ll have to figure out a proper loading strategy

aem-code-sync[bot] commented 1 month ago
Page Scores Audits Google
/news-and-stories/press-releases/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI