hlxsites / vg-volvotrucks-us

Franklin site for https://www.volvotrucks.us/
https://www.volvotrucks.us/
Apache License 2.0
2 stars 5 forks source link

[V2 Quote] - Inline Variant #635 #643

Closed cogniSyb closed 1 month ago

cogniSyb commented 1 month ago

Fix #635

Test URLs:

With the Helix v5 upgrade, a regression was caused by code that adds a paragraph. This breaks some alignment in existing quote blocks.

In this PR, I’m removing the blockquote from being needed in Word:

Screenshot 2024-05-21 at 15 59 36

It will become this, allowing more robust code as well:

Screenshot 2024-05-21 at 17 00 14

The new variant will be the default. The existing style will become a block option called with-background

aem-code-sync[bot] commented 1 month ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [b1b5f77](https://github.com/hlxsites/vg-volvotrucks-us/commit/b1b5f77186690f8759db0a0c9759d82e40483d84) :white_check_mark: (latest) * [cea7fe2](https://github.com/hlxsites/vg-volvotrucks-us/commit/cea7fe2257277972ad49f1bda4465a9070248316) :white_check_mark: * [acf4a4f](https://github.com/hlxsites/vg-volvotrucks-us/commit/acf4a4f28b0379f402f761f54a7dd0b707b16b4d) :white_check_mark:
aem-code-sync[bot] commented 1 month ago
Page Scores Audits Google
/all-new-vnl/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/drafts/syb/block/v2-quote PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/news-and-stories/volvo-trucks-magazine/going-the-extra-mile/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI