hlxsites / vg-volvotrucks-us

Franklin site for https://www.volvotrucks.us/
https://www.volvotrucks.us/
Apache License 2.0
2 stars 5 forks source link

Bug: [Columns] Tabbed Block is Broken #645

Closed ZoeBeykirch closed 2 weeks ago

ZoeBeykirch commented 1 month ago

Issue Type

Bug

Summary

[columns] [tabbed-carousel] is broken on Volvo USA and Canadian (FR and EN) websites

Priority

High

Description

The columns tabbed block is no longer working as expected. The tabs are not visible where the user clicks on the tab to reveal the associated text and imagery content. Now it is displaying all of the content as plain text and images vertically top to bottom on the page.

Affected Device Classes

Mobile, Tablet, Desktop

Affected Browsers/Devices and Versions

All browsers and devices

Steps to Reproduce

  1. Navigate to USA - https://www.volvotrucks.us/parts-and-services/parts/genuine/engine/
  2. Navigate to CA English - https://www.volvotrucks.ca/en-ca/parts-and-services/parts/genuine/engine
  3. Navigate to CA French - https://www.volvotrucks.ca/en-ca/parts-and-services/parts/genuine/engine
  4. See the block under "Genuine Cooling" is broken

Affected pages on VT US:

  1. https://www.volvotrucks.us/trucks/vnl/
  2. https://www.volvotrucks.us/trucks/vnl/exterior/
  3. https://www.volvotrucks.us/trucks/vnr/exterior/
  4. https://www.volvotrucks.us/trucks/vnl/interior/
  5. https://www.volvotrucks.us/innovation/electromobility/
  6. https://www.volvotrucks.us/trucks/vhd/interior/
  7. https://www.volvotrucks.us/trucks/vnx/exterior/
  8. https://www.volvotrucks.us/trucks/vnx/performance/
  9. https://www.volvotrucks.us/trucks/vnx/features/
  10. https://www.volvotrucks.us/trucks/vnr/interior/
  11. https://www.volvotrucks.us/trucks/vnx/interior/
  12. https://www.volvotrucks.us/trucks/vnr/features/
  13. https://www.volvotrucks.us/trucks/vah/features/
  14. https://www.volvotrucks.us/trucks/vnl/features/
  15. https://www.volvotrucks.us/trucks/vnr-electric/
  16. https://www.volvotrucks.us/trucks/vhd/exterior/
  17. https://www.volvotrucks.us/trucks/vhd/features/
  18. https://www.volvotrucks.us/parts-and-services/parts/remanufactured/engine/
  19. https://www.volvotrucks.us/parts-and-services/parts/genuine/engine/
  20. https://www.volvotrucks.us/purchasing-a-truck/volvo-certified/

Expected Results

Image

Actual Results

Image

cogniSyb commented 1 month ago

@ZoeBeykirch I had a fix that worked intermittently. This would reinstate the first carousel on the page, though others would be hidden. I’m leaving this fix for now as it would break more than currently is the case – it’s better to have all content shown instead of most hidden.

I’m currently looking into utilizing the [v2-tabbed-carousel] of Mack Trucks for this. As this situation is happening primarily on the truck pages that will be replaced, what is the outlook on the publication of the redesigned PDPs?

ZoeBeykirch commented 1 month ago

@cogniSyb Thanks for looking into this! Let's talk about the [v2-tabbed-carousel] of Mack Trucks solution tomorrow in standup/refinement - the Volvo redesigned PDPs are still in progress, but if this bug fix would require getting all those pages updated to the new redesign it would likely motivate that work to happen faster.

BeckyMedlin commented 1 month ago

@cogniSyb @verareljic @mollyaljenkins We need to determine root cause of this issue. Please document it here. If this block broke as a result of the Helix5 upgrade, we need to provide feedback to Darin at Adobe.

verareljic commented 1 month ago

@ZoeBeykirch please follow up with @williebender and update the ticket. Thanks.

girishdigrajkar commented 2 weeks ago

Observation: Mobile :

  1. https://645-tabbed-carousel--vg-volvotrucks-us--hlxsites.aem.page/drafts/syb/block/v2-tabbed-carousel-v1-page. as soon as you click on second tab the slight of third tab is displayed in V2 page however, not the case with this V1 page - needs to be addressed ( It is occurring for first image variant)
  2. For image variant above click on second tab and then scroll of image is not smooth ...especially observe at the end the image scrolls fast to left corner all of sudden
Screenshot 2024-06-12 at 2 57 13 PM
girishdigrajkar commented 2 weeks ago

For point 1 : https://github.com/hlxsites/vg-macktrucks-com/issues/706 will address it so taking out of scope from this ticket (discussed with Syb) cc: @mollyaljenkins For Point 2: Able to get the desired results

Hence, Closing the issue.