search

hlxsites / zemax

AEM Franklin Solution for https://www.zemax.com/
https://main--zemax--hlxsites.hlx.page/
Apache License 2.0
3 stars 1 forks source link

hero block for product pages #124

Closed agangam closed 1 year ago

agangam commented 1 year ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix # 76

Test URLs:

Comparison for opticsbuilder :

image image
aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/pages/opticsbuilder SI FCP LCP TBT CLS PSI
/pages/opticstudio SI FCP LCP TBT CLS PSI
/pages/opticstudio-star-module SI FCP LCP TBT CLS PSI
kunwarsaluja commented 1 year ago

@agangam You might want to review the rendering again as the text doesnt seem centered in all breakpoints and looks odd if you compare it with live site

Screenshot 2023-05-09 at 9 01 27 AM Screenshot 2023-05-09 at 9 01 19 AM Screenshot 2023-05-09 at 9 00 54 AM Screenshot 2023-05-09 at 9 00 47 AM
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/pages/opticsbuilder SI FCP LCP TBT CLS PSI
/pages/opticstudio SI FCP LCP TBT CLS PSI
/pages/opticstudio-star-module SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/pages/opticsbuilder SI FCP LCP TBT CLS PSI
/pages/opticstudio SI FCP LCP TBT CLS PSI
/pages/opticstudio-star-module SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/pages/opticsbuilder SI FCP LCP TBT CLS PSI
/pages/opticstudio SI FCP LCP TBT CLS PSI
/pages/opticstudio-star-module Lighthouse returned error: Something went wrong. PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/pages/opticsbuilder SI FCP LCP TBT CLS PSI
/pages/opticstudio SI FCP LCP TBT CLS PSI
/pages/opticstudio-star-module SI FCP LCP TBT CLS PSI
kunwarsaluja commented 1 year ago

@agangam Hero component doesnt look correct. Also the CLS is getting hit due to layout shift

Screenshot 2023-05-10 at 10 56 11 AM Screenshot 2023-05-10 at 10 56 26 AM

aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/pages/opticsbuilder SI FCP LCP TBT CLS PSI
/pages/opticstudio SI FCP LCP TBT CLS PSI
/pages/opticstudio-star-module SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/pages/opticsbuilder SI FCP LCP TBT CLS PSI
/pages/opticstudio SI FCP LCP TBT CLS PSI
/pages/opticstudio-star-module SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/pages/opticsbuilder SI FCP LCP TBT CLS PSI
/pages/opticstudio SI FCP LCP TBT CLS PSI
/pages/opticstudio-star-module SI FCP LCP TBT CLS PSI
kunwarsaluja commented 1 year ago

@agangam As the screen gets wider..the text within the hero blocks shifts left and renders in a weird way. We need to fix it for all breakpoints before i can merge

Screenshot 2023-05-12 at 9 23 50 AM Screenshot 2023-05-12 at 9 23 56 AM

kunwarsaluja commented 1 year ago

Closing as it's outdated now. Reopen incase of any concerns.