fix logout error on the console

hlxsites / zemax

AEM Franklin Solution for https://www.zemax.com/

https://main--zemax--hlxsites.hlx.page/

Apache License 2.0

3 stars 1 forks source link

fix logout error on the console #145

Closed agangam closed 1 year ago

agangam commented 1 year ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #144

Test URLs:

Before: https://main--zemax--hlxsites.hlx.page
After: https://issue-144-logout--zemax--hlxsites.hlx.page

LHS score for logout timestamp :

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

[ ] Re-run PSI Checks

aem-code-sync[bot] commented 1 year ago

Page	Score	PSI Audit	Google
/pages/profile		Lighthouse returned error: FAILED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Details: net::ERR_ABORTED)

aem-code-sync[bot] commented 1 year ago

Page	Score	PSI Audit	Google
/pages/profile		Lighthouse returned error: FAILED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Details: net::ERR_ABORTED)

aem-code-sync[bot] commented 1 year ago

Page	Score	PSI Audit	Google
/pages/profile		Lighthouse returned error: FAILED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Details: net::ERR_ABORTED)

shehjadkhan-ansys commented 1 year ago

@agangam @kunwarsaluja hexli-psi-check will fail as /pages/profile is only accessible once you login and thus the bot will fail. So you might have to update the before and after url to homepage url.

I wish we had a way to test the performance of authenticated/gated pages

kunwarsaluja commented 1 year ago

@shehjadkhan-ansys Yes we are aware off this and had sparked the discussion earlier internally.

The feature for this is now under development by other teams

aem-code-sync[bot] commented 1 year ago

Page	Score	PSI Audit	Google
/

aem-code-sync[bot] commented 1 year ago

Page	Score	PSI Audit	Google
/