hlxsites / zemax

AEM Franklin Solution for https://www.zemax.com/
https://main--zemax--hlxsites.hlx.page/
Apache License 2.0
3 stars 1 forks source link

fix tabcordion style and animation #161

Closed FrancoisZhang closed 1 year ago

FrancoisZhang commented 1 year ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #112

Test URLs:

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/pages/applications SI FCP LCP TBT CLS PSI
kunwarsaluja commented 1 year ago

@FrancoisZhang From the authors perspective, how would they get the direct link to the tab ?

can we populate like an href or some thing that authors can copy and use the direct link anywhere they want to reference this tab (eg . header, footer, pages) ?

FrancoisZhang commented 1 year ago

@kunwarsaluja yes, that makes sense, I just pushed another commit which make the URL hash change while switch tabs, so that author can get the URL by that

aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/pages/applications SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 1 year ago
Page Score PSI Audit Google
/pages/applications SI FCP LCP TBT CLS PSI