Fix #165: Do not wait for fetch. - Githubissues

hlxsites / zemax

AEM Franklin Solution for https://www.zemax.com/

https://main--zemax--hlxsites.hlx.page/

Apache License 2.0

3 stars 1 forks source link

Fix #165: Do not wait for fetch. #172

Closed synox closed 1 year ago

synox commented 1 year ago

Ideally the async code is moved to an async function like loadData, where all the async stuff happens with await instead of then(). And in function decorate(block)we don't await the call to loadData and show a spinner until completion.

Fix #165

Test URLs:

Before: https://main--zemax--hlxsites.hlx.page
After: https://165-no-wait-for-fetch--zemax--hlxsites.hlx.page

@shehjadkhan-ansys I know you plan to optimize this in the future. This is a minimal change to already improve the overall performance.

aem-code-sync[bot] commented 1 year ago

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed. In case there are problems, just click the checkbox below to rerun the respective action.

[ ] Re-run PSI Checks

aem-code-sync[bot] commented 1 year ago

Page	Scores	Audits	Google
/pages/profile		Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 403)

aem-code-sync[bot] commented 1 year ago

Page	Scores	Audits	Google
/pages/profile		Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 403)

aem-code-sync[bot] commented 1 year ago

Page	Scores	Audits	Google
/pages/profile		Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 403)

aem-code-sync[bot] commented 1 year ago

Page	Scores	Audits	Google
/