hlysine / create_connected

A Create mod add-on adding quality-of-life blocks that you wish existed in Create.
GNU Affero General Public License v3.0
28 stars 9 forks source link

[low priority] Render conflict with "Create: Extended Cogwheels" mod #10

Open mikkolukas opened 11 months ago

mikkolukas commented 11 months ago

This issue is really low priority. Everything works as expected except for the wrong item shown in-world.

Context

The bug shows when Create: Extended Cogwheels is installed alongside Create: Connected.

How to reproduce

  1. Place Shear Pin in the world.
  2. F3 shows it is Shear Pin
  3. The hitbox matches Shear Pin
  4. But: The 3D model is Shaftless Cogwheel from Create: Extended Cogwheels

2023-12-29_06 32 33

Observations

Cases

Same issue in all the following cases:

FIRST CASE Dedicated server Server OS :: Linux Minecraft :: 1.19.2 Forge :: 43.3.5 Create: 0.5.1f Create: Connected :: 0.2.0 (JEI was also installed due to dependency in 0.2.0) Create: Extended Cogwheels :: 2.1.0

SECOND CASE Local game OS: Windows 11 Minecraft :: 1.19.2 Forge :: 43.3.5 Create: 0.5.1f Create: Connected :: 0.3.0 Create: Extended Cogwheels :: 2.1.0

At Minecraft 1.20.1, there doesn't even exist a version of Create that satisfies both mods at the same time.

hlysine commented 11 months ago

A quick skim of C:EC's source code reveals that the issue is caused by Extended Cogwheels patching the BracketedKineticBlockEntity class that the Shear Pin inherits from. Not really inclined to fix this one because it is up to Extended Cogwheels to not treat all "simple kinetic blocks" that are not ordinary shafts to be cogwheels.

Maybe you can open an issue on their side and see if they're willing to fix this?

mikkolukas commented 11 months ago

Thanks for your fast response.

I'll need to get some sleep, but I will open an issue on their side ASAP (they also need to put in a bit of work to get it up to date 😉 )

hlysine commented 11 months ago

Update: opened a new issue on their side because multiple users are noticing the bugs https://github.com/Rabbitminers/Extended-Cogwheels/issues/83