search

hm21 / pro_image_editor

The pro_image_editor is a Flutter widget designed for image editing within your application. It provides a flexible and convenient way to integrate image editing capabilities into your Flutter project.
https://hm21.github.io/pro_image_editor/
BSD 3-Clause "New" or "Revised" License
119 stars 69 forks source link

[Bug]: The crop drag conflicts with Android navigation gestures. #170

Closed francescodinova closed 2 months ago

francescodinova commented 3 months ago

Package Version

4.2.5

Flutter Version

3.22.2

Platforms

Android

How to reproduce?

I found the bug on a Samsung S22 device with Android 14 that has navigation gestures enabled. When I try to drag the side handles of the crop, the device recognizes the back gesture, and subsequently, the crop area no longer resizes consistently.

Logs (optional)

No response

Example code (optional)

No response

Device Model (optional)

Samsung Galaxy s22 (Android 14)

hm21 commented 3 months ago

Okay, this problem might be a bit tricky to fix. I think the system back button from Android should still work, but the back swipe we should disable. However, I don't currently have a native android device to test it in a good way. Can you maybe fork this repository and just wrap the full body in crop-rotate-editor inside the popscope and tell me if it works correctly?

PopScope(
      canPop: !Navigator.of(context).userGestureInProgress,
      child: /// content
github-actions[bot] commented 2 months ago

This issue is stale because it has been open for 14 days with no activity.

github-actions[bot] commented 2 months ago

This issue was closed because it has been inactive for 5 days since being marked as stale.