hmatuschek / qdmr

A GUI application for configuring and programming cheap DMR radios under Linux and MacOS X.
https://dm3mat.darc.de/qdmr/
GNU General Public License v3.0
223 stars 46 forks source link

Channels are confusing without zone #299

Closed fxkr closed 1 year ago

fxkr commented 1 year ago

Often, a channel only makes sense in the context of a zone. On the actual radios, this is not a problem, as the zone name is usually displayed next to the channel name. But inside QDMR, the zone name is not displayed next to the channel name.

This can get confusing. Currently, the only way to keep track of what is what in the channel list in QDMR is to prefix the channel name with something like the zone name.

This is a problem, because many radios have limited display space. For example, channel names are max 16 chars in OpenGD77.

For example, if I add channels for all the repeaters in the CARLA repeater network (K6LNK), I feel like I need to prefix the channel name with "K6LNK" or similar just so I won't confuse these channels with others. That leads to running out of space for the rest of the repeater name (e.g. "South Lake Tahoe" won't fit; best I can do is "SLTahoe"). This is unfortunate because it is such an unnecessary problem, as that prefix is entirely for QDMR - I can just add the channels to a zone, and the radio will then show the zone name next to it.

image

I can think of two ways to improve the usability here, either:

  1. Add a free text comment field that the QDMR user can use and that is not synced to the radio in any way, or
  2. Add an auto-calculated, read-only column to the channels list that shows the zones that the channel is currently part of.
hmatuschek commented 1 year ago

Concerning FM channels, this makes sense. There is no information associated with these, that groups channels like talkgroups for DMR channels. To this end, adding a column listing the zones, these channels are members of, would make sense.

hmatuschek commented 1 year ago

Ok, implemented. If you like, you can test it in the show-zones-in-channel-list branch.

fxkr commented 1 year ago

Wow, that was fast! Tested. Thank you so much, this is exactly what I needed.

As an unexpected side benefit, it is now very obvious when there are channels that by accident aren't in any zone at all, and are thus unavailable in the radio..

fxkr commented 1 year ago

There seems to be a bug. The first channel in each zone has an empty Zones field.

This can be readily reproduced with a new codeplug for example by creating three channels, and a zone with all three.

image image

fxkr commented 1 year ago

In lib/configobject.cc, return 0 < indexOf(obj) should be return 0 <= indexOf(obj).

hmatuschek commented 1 year ago

You are right, thanks.

allesand commented 1 year ago

Cool new feature! Indeed helps to keep things sorted.