search

hmatuschek / qdmr

A GUI application for configuring and programming cheap DMR radios under Linux and MacOS X.
https://dm3mat.darc.de/qdmr/
GNU General Public License v3.0
216 stars 45 forks source link

GD73 interface crashes if USB device cannot be claimed. #398

Closed hmatuschek closed 11 months ago

hmatuschek commented 11 months ago

Crash is fixed, however. It is not clear, why the USB device cannot be reclaimed. Needs to be fixed too.

allesand commented 11 months ago

Interesting: Reading (or writing) the config works more than once in a row - detecting the radio or checking the config only once.

Side note: now if we can ever find out how to disable that very annoying "startup sound"..

hmatuschek commented 11 months ago

There are two unknown bytes, that are set to 0x01, I wonder, what happens, if you set them to 0x00.

https://github.com/hmatuschek/qdmr/blob/35cc75afc5d5be5a40c78b20ac42578c4e4bf12e/lib/gd73_codeplug.cc#L462-L463

The third byte turned out to be the UI language setting.

allesand commented 11 months ago

Before we "boldly go where no man has gone before" - is there a GUI setting for "BootDisplayMode" (yet)? It seems to be set to "Invisible"/"Off" on write, so no "Animation" and no "Custom Text" on power-on, or did I overlook s.th.?

hmatuschek commented 11 months ago

I've added it just today in the https://github.com/hmatuschek/qdmr/tree/397-extend-radioddity-settings-extension-to-cover-gd73-settings branch.

allesand commented 11 months ago

Aye, there's the rub - wrong branch, was on https://github.com/hmatuschek/qdmr/tree/398-gd73-interface-crashes-if-usb-device-cannot-be-claimed - switched - compiling..

hmatuschek commented 11 months ago

Should be fixed now. Missed closing the raw USB connection to the device upon destruction of the radio (GD73) object.

allesand commented 11 months ago

So qdmr was holding on to the hat radio longer than it should have - that issue solved! Let me check the "boot text" settings..

Still "invisible" - set it via the Windows-CPS, read radio - text in "Intro Line 1/2", boot -> display set to "Text", but after writing the config, the "Intro Lines" are not shown, on all three settings ("None", "Text" and "Image"). Oh. When writing "Image" to the radio and reading back in, it is read as "None" - that is strange? Ah! For all settings in qdmr, when reading from the radio afterwards, boot -> display is displayed as "None" - which is exactly how the radio behaves. Does that mean that qdmr is writing in a way the radio interprets it as "None" regardless of the setting in qdmr?

hmatuschek commented 11 months ago

Ok, then let me close that issue here and remove the branch. The boot-settings branch is in issue #397.