search

hmazter / laravel-schedule-list

Laravel package to add command to list all scheduled artisan commands
MIT License
94 stars 14 forks source link

Check if filters pass for the event #36

Closed crlcu closed 4 years ago

hmazter commented 4 years ago

Thank you for your contribution. I'm not totally sure that this change is what everyone wants all the time.

I can see you want to get all the events that are about to run now with this. But in the case that you want an overview of all the commands and when they will run, this change will remove some rows, and that is not the desired behavior according to me.

Did it understand it correctly?

crlcu commented 4 years ago

I think I got your point.

You saying this package is meant to list all the commands that has a schedule, no matter if they will ever be executed or not (some filters might be based on things that are changing over time, e.g.: when(dynamic condition)).

When I made this pull request I've had in mind only the scenario for when(static condition) such as a config value.