search

hmellor / auction-website

An open-source auction hosting system
https://hmellor.github.io/auction-website/
MIT License
106 stars 49 forks source link

auction-live is unavailable #20

Closed man-chen-TW closed 1 year ago

man-chen-TW commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'submit bid'
  2. Click on 'submit bid'
  3. Scroll down to '....'
  4. See error auctions.js:146 Uncaught (in promise) TypeError: Cannot convert undefined or null to object at Function.keys () at auctions.js:146:26

Additional context

Firestore has not any auction-live data

man-chen-TW commented 1 year ago

image After linking Firebase, all starting prices disappear, please function becomes unavailable.

dijkhuiz commented 1 year ago

I am also experiencing this issue.

hmellor commented 1 year ago

I have been able to reproduce your issue by updating to the latest Firebase. master is on SDK 6.5.0, whereas the code snippets when creating a new project will be on SDK 9.20.0.

I'm working on updating this in #21

hmellor commented 1 year ago

@man-chen-TW, @dijkhuiz: Please try with v2.2.0 (check the updated instructions too), I have updated to the latest Firebase SDK in #21

dijkhuiz commented 1 year ago

Awesome! Thank you so much for the quick follow-up and you great work!

I pulled the latest version and followed your updated instructions. It seems that something is going wrong with the authentication part. I think it has some issues with the import. I get the following error: caught (in promise) TypeError: auth.signInAnonymously is not a function at popups.js:55:12 at auth_impl.ts:603:14

This is a new error based on the update you did. I think you already had a user on the system you did the testing, so this error was not thrown. It only runs the function auth.signInAnonymously() when a user is not know. Do you have any idea what could cause this error? I checked and you did import auth in the firebase.js-file. You then created a constant that is exported with the name auth in that file as well. Furthermore, in popup.js you are importing auth from firebase.js.

I do not understand why it does not recognizes the function. I have a feeling it has something to do with the import and references between files. Do you have any idea?

hmellor commented 1 year ago

You're right, I was already signed in to an account when I made that release. I'll fix it and bump the release tag until it works (no point in a broken release)

hmellor commented 1 year ago

@dijkhuiz I've put some work in over the weekend to fully update the whole repo. I'm sure I could sit here longer and come up with more things to change/add, but for the moment I'm happy with it.

Please check out the latest release (Release v2.4.0) as I've added some cool features (such as a monitoring dashboard) that you'll probably find helpful when you run your auction.

hmellor commented 1 year ago

Closing as this is for an old version of the site