Closed Zelenya closed 6 years ago
I must say, I really like it! However, it creates a bit of perceived whitespace around the images now, I may have to trim it (at least, for print). @BartoszMilewski, your thoughts?
Before | After |
---|---|
Hm, not sure about whitespaces, I didn't change image size/resolution, will check it
Yeah, the sizes are the same, but now it seems there are bigger margins around the images (because of the white background). I'll tweak it in LaTeX 😅😅
It looks good imho, I think only the wrapped ones may need a bit of margin reduction in latex
Updated rest of the pictures.
Only not sure about 3.8 pics:
now could be like this or like this
I think the first one. I really like the result, are there more? Let me know when I can merge :)
@hmemcpy if you like the first (current) one, then there should be nothing left to change. Good to go
Looks great! I just built a local copy and skimmed it - really nice job! In 3.13 (Topoi) some images seem to have the background still - maybe you missed those?
@hmemcpy oh, yeah :frowning:
Also feel free to add yourself to the README.md file under contributors :)
@hmemcpy 3.13
is also done
Great job, thank you!
Hey @Zelenya, I found a few more images with backgrounds: in 3.8 - F-Algebras in 3.12 - Enriched Categories
And that's it :)
Do you think you could send another PR?
:rage: sneaky I'll fix it tomorrow
Thanks!
First batch to see if it makes sense to continue. @hmemcpy @BartoszMilewski What do you think?