hmemcpy / milewski-ctfp-pdf

Bartosz Milewski's 'Category Theory for Programmers' unofficial PDF and LaTeX source
https://bartoszmilewski.com/2014/10/28/category-theory-for-programmers-the-preface/
Other
10.91k stars 581 forks source link

[WIP] Remove bg from the pictures #139

Closed Zelenya closed 6 years ago

Zelenya commented 6 years ago

First batch to see if it makes sense to continue. @hmemcpy @BartoszMilewski What do you think?

hmemcpy commented 6 years ago

I must say, I really like it! However, it creates a bit of perceived whitespace around the images now, I may have to trim it (at least, for print). @BartoszMilewski, your thoughts?

Before After
s1-a s1-z
s2-a s2-z
s3-a s3-z
Zelenya commented 6 years ago

Hm, not sure about whitespaces, I didn't change image size/resolution, will check it

hmemcpy commented 6 years ago

Yeah, the sizes are the same, but now it seems there are bigger margins around the images (because of the white background). I'll tweak it in LaTeX 😅😅

mseri commented 6 years ago

It looks good imho, I think only the wrapped ones may need a bit of margin reduction in latex

Zelenya commented 6 years ago

Updated rest of the pictures.

Only not sure about 3.8 pics:

now 0 could be like this 2 or like this 1

hmemcpy commented 6 years ago

I think the first one. I really like the result, are there more? Let me know when I can merge :)

Zelenya commented 6 years ago

@hmemcpy if you like the first (current) one, then there should be nothing left to change. Good to go

hmemcpy commented 6 years ago

Looks great! I just built a local copy and skimmed it - really nice job! In 3.13 (Topoi) some images seem to have the background still - maybe you missed those?

Zelenya commented 6 years ago

@hmemcpy oh, yeah :frowning:

hmemcpy commented 6 years ago

Also feel free to add yourself to the README.md file under contributors :)

Zelenya commented 6 years ago

@hmemcpy 3.13 is also done

hmemcpy commented 6 years ago

Great job, thank you!

hmemcpy commented 5 years ago

Hey @Zelenya, I found a few more images with backgrounds: in 3.8 - F-Algebras in 3.12 - Enriched Categories

And that's it :)

Do you think you could send another PR?

Zelenya commented 5 years ago

:rage: sneaky I'll fix it tomorrow

hmemcpy commented 5 years ago

Thanks!