search

hmemcpy / milewski-ctfp-pdf

Bartosz Milewski's 'Category Theory for Programmers' unofficial PDF and LaTeX source
https://bartoszmilewski.com/2014/10/28/category-theory-for-programmers-the-preface/
Other
10.88k stars 578 forks source link

OCaml version missing images and text runs off the page #232

Closed ddickstein closed 4 years ago

ddickstein commented 4 years ago

This issue really pertains to Arulselvan Madhavan's fork but issues aren't enabled for the fork so I'm adding it here.

I'm following #201 and saw that the final chapters were in, so I went ahead to try building it and seeing how it turned out. After addressing the various dependency complaints by make ocaml I was able to generate two pdfs that had the OCaml code snippets, but images were missing and the snippets often were cut off.

Are there some dependencies I'm missing that's causing this behavior?

I've checked out the OCaml branch of the fork at commit 56c552e1fb18be3fdaf7975b8b250dee89048644. The generated output version is v1.2.1-52-g56c552e.

Cut off text

cut-off-text

Missing image

missing-image

mseri commented 4 years ago

For the first one, it did came out early on in my reviews as well. Ideally we should have the code be auto formatted by ocamlformat, although I don’t know how much we can automate it in the current structure of things. It may be that it is going to be all manual work :-/

hmemcpy commented 4 years ago

Yeah, sorry about that... I ended up manually formatting all files for the Scala edition :(

hmemcpy commented 4 years ago

I'm not sure why some images are missing, will take a look...

ArulselvanMadhavan commented 4 years ago

@ddickstein I have run the formatter and enabled issues in my fork

hmemcpy commented 4 years ago

Gah. I figured out why the images were missing... a long story short, a recent TexLive update fixed an issue with paths containing spaces, and another package was interfering with that (\usepackage[multidot]{grffile}). So I removed it, and now the images are working again. Images should be rendering now.