search

hmemcpy / milewski-ctfp-pdf

Bartosz Milewski's 'Category Theory for Programmers' unofficial PDF and LaTeX source
https://bartoszmilewski.com/2014/10/28/category-theory-for-programmers-the-preface/
Other
10.94k stars 587 forks source link

Make OCaml code samples closer to Haskell (chapters 1 to 4) #242

Open yawaramin opened 4 years ago

yawaramin commented 4 years ago
ArulselvanMadhavan commented 4 years ago

Even if we haven't reached a conclusion on whether we should write compilable snippets, I still think the changes in this PR, especially the ones that remove dependency on external libraries, are important. Thanks for fixing the order @yawaramin! I don't know when/how they got out of order

cc: @mseri @XVilka

yawaramin commented 4 years ago

Thanks @ArulselvanMadhavan I can work on more chapters as well, am enjoying reading through the book.

XVilka commented 4 years ago

Looks much cleaner and easier to read, indeed 👍

mseri commented 4 years ago

I agree. Looks good. Thanks @yawaramin

yawaramin commented 4 years ago

Cheers guys, I appreciate the review 👍

fhammerschmidt commented 4 years ago

Will this be merged? If so I will adapt the examples accordingly in my Reason branch, too.

hmemcpy commented 4 years ago

Sorry for not attending to this. Are there more changes coming? Also, does this tie to the prelude discussion in #237?

yawaramin commented 4 years ago

@hmemcpy hi, no problem. I've made some progress on Chapter 5 locally, if there is interest I can send more as I cover more chapters. It will be a good distraction for me from constantly obsessing over the news :-)

hmemcpy commented 4 years ago

I think a distraction would be welcomed for everybody!

francoisthire commented 4 years ago

What is the current status of this MR? Is there a way to help? What about the other chapters?

yawaramin commented 4 years ago

@hmemcpy would you prefer this PR to cover the whole book? Or separate PRs for a few chapters at a time?

hmemcpy commented 4 years ago

Hey all! So sorry for neglecting the PR! Would love to merge it. Can any of you verify there are no more changes? Unless you'd like to contribute the rest of the chapters as well?

drupol commented 2 years ago

Hi, what's the status of this PR ?

hyphenrf commented 1 year ago

@yawaramin I'm reading the book right now, and I'm happy to help if you're still working on this. If not, I can take it from here and revise the rest of the chapters.

yawaramin commented 1 year ago

@hyphenrf hey that would be great, please feel free. I agree with all your comments btw.

drupol commented 1 year ago

Hi all,

What is the status of this PR ?

Thanks

hyphenrf commented 1 year ago

hi @drupol, I haven't finished reading the book. I have notes written all over the OCaml impl, and once I've finished the book, I'll create a patch with all the edits and which closes this PR.

drupol commented 1 year ago

Cool, glad to see it's still alive then.

Looking forward for reviewing your pull request.

Cheers!