search

hmemcpy / milewski-ctfp-pdf

Bartosz Milewski's 'Category Theory for Programmers' unofficial PDF and LaTeX source
https://bartoszmilewski.com/2014/10/28/category-theory-for-programmers-the-preface/
Other
10.84k stars 575 forks source link

ReasonML edition. #247

Closed fhammerschmidt closed 3 years ago

fhammerschmidt commented 4 years ago

I converted the OCaml edition thanks to the Reason parser which can translate OCaml into Reason source code (and vice versa). Not everything did compile or typecheck, so there was still some manual work necessary.

I figured if I wanted to learn category theory, I'd rather do this in my everyday language so here's the ReasonML edition of CTFP!

hmemcpy commented 4 years ago

Oh wow! This is great, thank you :) I don't speak ReasonML, so please feel free to tag people you'd think could give a hand in reviewing this! I'd be happy to merge it once you're satisfied with it!

fhammerschmidt commented 4 years ago

Of course.

@yawaramin @mlms13 @andywhite37 @Risto-Stevcev or anybody who feels like it, please review if you want.

andywhite37 commented 4 years ago

@fhammerschmidt - this is really cool! I've been meaning to check out this book, so this is a good excuse. I don't know if I'll have time to do a thorough review, but the stuff I saw at a quick glance looked good.

fhammerschmidt commented 3 years ago

Can we please merge this?

It's probably not perfect for now, because I am still waiting for #242 to adapt, but I think it is better to have the bulk merged now.

drupol commented 3 years ago

We need to also update the Github actions workflow to include this new edition.

hmemcpy commented 3 years ago

Yeah, very sorry for neglecting! :( Would be happy if you rebased on top of the latest changes to make sure all build workflows are included. Will be happy to merge then.

fhammerschmidt commented 3 years ago

Rebased and added Reason to workflows: https://github.com/hmemcpy/milewski-ctfp-pdf/pull/247/commits/a537ebd9faafcbe753ae746e9ae30b4858f21799

hmemcpy commented 3 years ago

Amazing, let's do this! 🎉

hmemcpy commented 3 years ago

Thanks all very much for your contributions!!