search

hmemcpy / milewski-ctfp-pdf

Bartosz Milewski's 'Category Theory for Programmers' unofficial PDF and LaTeX source
https://bartoszmilewski.com/2014/10/28/category-theory-for-programmers-the-preface/
Other
10.84k stars 575 forks source link

Replace template<class> with template<typename> #260

Closed matssson closed 9 months ago

matssson commented 3 years ago

Since the book focuses heavily on types, I think that the C++ keyword typename is more appropriate, clear and avoids confusion for those less experienced with C++, and I think it's generally good practice to use typename instead of the overloaded meaning of class.

I also added a missing step in the composition argument for fmap Nothing and fixed some whitespace formatting. There is trailing whitespace in the licence file and in errata-1.0.0.md, but I didn't change them since I think it's more interesting for the readers to know when they were last updated properly.

drupol commented 1 year ago

Dear @matssson,

Do you plan to implement the changes in this PR ?

Thanks

matssson commented 1 year ago

I fixed the changes now in a new PR https://github.com/hmemcpy/milewski-ctfp-pdf/pull/309

I redid the trailing whitespace part since there were a lot of changes since the original PR.