search

hmemcpy / milewski-ctfp-pdf

Bartosz Milewski's 'Category Theory for Programmers' unofficial PDF and LaTeX source
https://bartoszmilewski.com/2014/10/28/category-theory-for-programmers-the-preface/
Other
10.84k stars 572 forks source link

Updated README.md as per issue #288 #289

Closed mlliarm closed 2 years ago

mlliarm commented 2 years ago

Before this commit the instructions in the README.md weren't accurate enough to allow one to build the Scala version of the PDF following them (make and make scala failed miserably).

In this commit I did my best to transfer the updated instructions that were given by @drupol at issue #288 and I can confirm that they work like a charm on my GNU/Linux laptop.

Thanks !

mlliarm commented 2 years ago

You're totally right. Should I cancel the PR, add the instructions in the README and create a new PR? Thx!

Michail L. Liarmakopoulos, MSc

On Sun, Apr 3, 2022, 15:11 Pol Dellaiera @.***> wrote:

@.**** requested changes on this pull request.

That's a good start!

However, the link to enable flakes features is pointing to a wiki, which might be subject to change. Maybe it would be better to include those steps in stone in this readme ? WDYT ?

— Reply to this email directly, view it on GitHub https://github.com/hmemcpy/milewski-ctfp-pdf/pull/289#pullrequestreview-929672416, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMQENTCVQYH7QT4TACHQLDVDGKGTANCNFSM5SNFCNHQ . You are receiving this because you authored the thread.Message ID: @.***>

drupol commented 2 years ago

You can just update this PR by pushing to this branch ! :)

mlliarm commented 2 years ago

@drupol when you have the time kindly review the commit dd94e70 :) Thanks !

drupol commented 2 years ago

Thanks !!

drupol commented 1 year ago

?