Closed amacmillanparks closed 1 year ago
Hi,
Thanks for contributing!
This issue seems legit to me, but as I don't have much knowledge in Scala, I'll wait to have more feedback from any other contributor that can help in here.
Thanks @drupol! Some colleagues and I have been reading through the book and just noticed this in the last chapter we read.
The change should be pretty self explanatory, but happy to discuss more if it'd help.
Hi,
Thanks ! Ok then it's fine for me.
@hmemcpy Ok for you as well ?
@hmemcpy ^^
Oh wow, sorry for missing this.
It looks fine, though I'd prefer to use the more idiomatic .flatMap
style (with the dot, instead of infix).
Either way this should be fine.
@amacmillanparks Are you planning to implement the changes requested by @hmemcpy ?
Hi @drupol & @hmemcpy, sorry, I've just seen this now. Thanks for the feedback, I'll go ahead and make the change.
That's all done now, please can you re-review?
The CI has spoken but I'll wait for @hmemcpy to review this !
Sorry, one more comment: since we're using the native flatMap
method (and not the bind syntax >>=
), the import bindSyntax._
line can also be removed.
No worries, that's all done now.
Fantastic, thanks very much for your contribution! And sorry it took a while ;)
As per issue #296, the Scala edition snippets 22 and 23 are identical when snippet 23 should be a desugared version of snippet 22. This PR fixes that.