search

hmemcpy / milewski-ctfp-pdf

Bartosz Milewski's 'Category Theory for Programmers' unofficial PDF and LaTeX source
https://bartoszmilewski.com/2014/10/28/category-theory-for-programmers-the-preface/
Other
10.93k stars 587 forks source link

A mistake in Section 6.3 #316

Closed daleydeng closed 1 year ago

daleydeng commented 1 year ago

image this should be this image

from original blog https://bartoszmilewski.com/2015/01/13/simple-algebraic-data-types/

Because, Either is not data constructor which needed in data decalration

drupol commented 1 year ago

Nice catch, could you submit a PR to fix it ?

daleydeng commented 1 year ago

seem already merged

drupol commented 1 year ago

It's merged in your fork. Could you submit the PR against this project?

hmemcpy commented 1 year ago

I saw @BartoszMilewski merge this (or, a similar fix https://github.com/hmemcpy/milewski-ctfp-pdf/pull/315) not too long ago. Are we sure this is still current? Or is it another place in the book?

drupol commented 1 year ago

Indeed, it's already merged, we can close this issue.