search

hmerk / main_widget

Repository for colaboration in the main_widget project
Eclipse Public License 2.0
2 stars 2 forks source link

FloorsAndRoomCard: Change creation of title for LightCard #19

Closed Rosi2143 closed 1 year ago

Rosi2143 commented 1 year ago

uiSemantics is based on points of equipments to this point is used to create the title instead of the equipment itself

Signed-off-by: Rosi2143 Schrott.Micha@web.de

hmerk commented 1 year ago

Still not answered my first question.

Rosi2143 commented 1 year ago

Hi,

sorry missed the first question.

In my setup the equipment is not part of another equipment - and iI suppose this is a general rule. So the uiSemantic of the equipment does not exist at all, or at least loop.lightItem.metadata.uiSemantics.config.equipment is empty. This makes the title something like "im Wohnzimmer" instead of "Licht im Wohnzimmer".

As we have the item already - with full uiSemantic - this seems to be the more appropriate solution

It removes an implicit rule that an equipment must have a loop.lightItem.metadata.uiSemantics.config.equipment pointing to itself.

hmerk commented 1 year ago

There is no rule to use uiSemantics at all. If not used, the label of the equipment is considered. This should also work if for some reason not having a switch in the group. I need to think about that topic a bit more, as I see several different use cases, but for now, I would like to not implement that change and close this PR. For not to forget this topic, I will open an issue for this change request.

hmerk commented 1 year ago

Superseeded by #39