hmerk / main_widget

Repository for colaboration in the main_widget project
Eclipse Public License 2.0
2 stars 2 forks source link

new MainWidgetPresence_Card #22

Closed Rosi2143 closed 1 year ago

Rosi2143 commented 1 year ago

Add a card to display who is currently present.

Same base as the SceneCard and same config options

Signed-off-by: Rosi2143 Schrott.Micha@web.de

hmerk commented 1 year ago

Please do not just add new cards with a PR but first open an issue with a feature request to discuss if this is something to add to the project. Furthermore the styling of your card does not fit our styleguide.

hmerk commented 1 year ago

Please donโ€˜t comit changes for different widgets here. I would prefer single PRs for every widget. And please do not reorder my repeater code. Even the suggestion in editor is ordered different, how I coded is more logical and better to read.

I need to check your changes and see how it looks like. Better to post a screenshot when making additions.

Rosi2143 commented 1 year ago

Sorry - that was not intended to be merged. I pushed it to the wrong branch.

hmerk commented 1 year ago

๐Ÿ˜‰๐Ÿ‘