search

hmerritt / php-imdb-api

PHP IMDB-API that can fetch film data and search results
Apache License 2.0
59 stars 22 forks source link

rating_votes is empty #19

Closed adminko-svk closed 1 year ago

adminko-svk commented 1 year ago

Hi, rating_votes attribute is empty due to changed IMDb HTML structure for this value. Please check and fix. Thank you.

adminko-svk commented 1 year ago

I changed imdb-api/src/HtmlPieces.php:121 to $patterns = [".sc-bde20123-3"]; as a temporary solution.

hmerritt commented 1 year ago

I changed imdb-api/src/HtmlPieces.php:121 to $patterns = [".sc-bde20123-3"]; as a temporary solution.

I have added this as a hotfix, since it does work.

It is somewhat hard to find a more stable pattern given the markup.

I tried to use the data in __NEXT_DATA__ script, but this is not always present, so I abandoned it.

Will look into other options, for now though I've added the hotfix and will close this issue.

Thanks for making the issue and feel free to create more if any other issues crop up!