hmes98318 / Music-Disc

A Discord music bot, supports YouTube, Spotify, SoundCloud, Deezer streams and web dashboard.
https://musicdisc.ggwp.tw
MIT License
107 stars 105 forks source link

'maxvol' not working properly #3

Closed HTF8 closed 1 year ago

HTF8 commented 1 year ago

The maxvol setting will not kick in until the volume level is manually changed, also causing it to reset when the bot rejoins the chat, whether leaving via autorejoin being set to false, DCing, or being booted. If you set the volume, then maxvol will activate. This makes the maxvol setting redundant, because if the bot doesn't leave the chat, his volume will stay the same anyway. In the screenshot below my maxvol is set to 35, but the initial volume is at 100 when playing a song. When I set it to 35, it correctly changes to 35/35.

image

image

hmes98318 commented 1 year ago

Show me your Music-Disc version and dependency modules version.

HTF8 commented 1 year ago

@hmes98318 thanks. let me know if these are the right ones.

  "name": "music-disc",
  "version": "1.2.1",
  "description": "Discord Music Bot",
  "main": "index.js",
  "dependencies": {
    "discord-player": "~5.3.1",
    "discord.js": "^14.5.0",
    "dotenv": "16.0.2",
    "express": "^4.18.1",
    "ffmpeg-static": "~5.1.0",
    "ms": "2.1.3",
    "opusscript": "~0.0.8"
  },
hmes98318 commented 1 year ago

@HTF8 , you need to use npm list command to get dependency modules. If the discord-player version is 5.3.1 may get some volume problems try npm update discord-player to update dependency module.

OR update Music-Disc to the latest.

HTF8 commented 1 year ago

@hmes98318

├── discord-player@5.3.2
├── discord.js@14.5.0
├── dotenv@16.0.2
├── express@4.18.2
├── ffmpeg-static@5.1.0
├── ms@2.1.3
└── opusscript@0.0.8
npm update discord-player

up to date, audited 143 packages in 4s

27 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
HTF8 commented 1 year ago

I updated Music-Disc to latest and reconfigured my config.json, seems to be working as expected now. Thanks!