search

hmil / RosHTTP

Unified Scala.js + Scala HTTP client API
MIT License
126 stars 24 forks source link

#71:adding implicit conversion for boolean JSON value #72

Closed rajeevprasanna closed 6 years ago

rajeevprasanna commented 6 years ago

Currently we are not able to pass boolean values as request parameters as implicit json converters are not available for boolean type. Add that now.

Refer issue : #71

hmil commented 6 years ago

Could you add a test for this new feature ? (maybe just add a couple boolean values there to test both states) Also I believe the reason the CI build fails is because of an outdated scala-js-env-selenium dependency. Try bumping the version to 0.2.0 in plugins.sbt.

Thanks

hmil commented 6 years ago

Well looks like they introduced an API breaking change in a minor update. You could try using non-wildcard imports for the scajs-env stuff in project/InBrowserTesting.scala as shown in this working example. Also line 88 should be Firefox() instead of Firefox (and supposedly the same for Chrome).

Sorry for the mess but as I'm not actively using nor developing this project nowadays I don't even have a local clone of it. It's really up to the users community to keep it working.

hmil commented 6 years ago

@sjrd any idea why the tests fail ? I reproduced on my local computer and got the exact same result as in CI. The weird thing is it used to work and all of a sudden it stopped working while the codebase of RosHTTP did not change in months. I think it's due to some incompatibility buried deep into the dependencies of scala-js-env-selenium but I don't get why it would happen in RosHTTP but not in other projects using scala-js-env-selenium...