search

hmil / RosHTTP

Unified Scala.js + Scala HTTP client API
MIT License
126 stars 24 forks source link

Drop Scala 2.10, 2.11, add Scala 2.13 #88

Closed bilki closed 4 years ago

bilki commented 5 years ago

Hi @hmil, I was going to ask about 2.13 migration, but started to toy a bit with dependencies and ended up with a minimal PR that works for 2.12 and 2.13 (whole test set is green). It's still a sketch that we can work on top of.

The main problem here is that Scala support for 2.10 and 2.11 needs to be dropped, and I'm not sure if you still want to maintain them in the short term. Also bumping monix ends up with a bunch of unsafe methods that still require a bit of polishing.

hmil commented 5 years ago

Hi @bilki ,

Thank you for this contribution.

I am not using RosHTTP anymore so I don't care which Scala version it supports tbh. If you think 2.10 and 2.11 are old enough to be dropped it's your call.

It looks like travis is having troubles setting up oracle jdk. Can you try to change that with openjdk8 in the travis config file?

bilki commented 5 years ago

Oh, sorry to hear that @hmil. Of course, I'll try to improve this PR in order to apply your suggestion for travis and maybe some other changes.