To scala 2.13 and scalajs 1.0

hmil / RosHTTP

Unified Scala.js + Scala HTTP client API

MIT License

126 stars 24 forks source link

Closed mathieuleclaire closed 4 years ago

mathieuleclaire commented 4 years ago

hmil commented 4 years ago

Thanks a lot for your help. I will try to figure out how to reenable in-browser testing.

mathieuleclaire commented 4 years ago

You're welcome ! Thanks for finishing the job ! There are 2 errors in the CI checks that I do not reproduce locally:

scalastyle complains
[error] org.scalajs.testing.common.RPCCore$ClosedException:org.scalajs.testing.adapter.JSEnvRPC$RunTerminatedException

On, my machine, both tests work fine. Is the exception raised related to the browser testing ? We are very close :)

hmil commented 4 years ago

It's the stress test which is pushing the vms on travis to their limits. You have disabled the browser tests in this PR.

mathieuleclaire commented 4 years ago

It sounds good for a release :)