search

hmis-tools / hmis-api-server

Version 2 of OpenHMIS
Mozilla Public License 2.0
15 stars 11 forks source link

Third-party Javascript fetched from remote servers. #69

Open kfogel opened 8 years ago

kfogel commented 8 years ago

In src/main/webapp/signup/index.html there are a couple of places where we fetch Javascript files from remote servers. That's a Thing We Don't Do, so, you know, let's fix it.

kfogel commented 8 years ago

Branch 69-local-js is for this issue.

kfogel commented 8 years ago

I've confirmed that deploying branch 69-local-js (commit 907ed6d0e) breaks signup -- you go to /openhmis/signup and click the button but no authentication window with Google pops up -- yet if you deploy master at commit 650fce4436 (i.e., without any of the branch's changes), it still works.

What I don't know yet is whether this is specific to just the Google client:platform.js library. If we load jquery.min.js from our own server, while still loading Google's client:platform.js from apis.google.com, do things work then?