search

hmislk / hmis

This is an Open Source Java EE based Hospital Information Management System
Other
133 stars 80 forks source link

Issue#3020 #6324

Closed buddhika75 closed 2 weeks ago

buddhika75 commented 2 weeks ago

There was an error while closing shift end. Corrected. Introduced by @Thiwanka570 -

Null Pointer on Closing the Shift

Error

System.out.println("fundTransferBillTocollect = " + fundTransferBillsToReceive.size());
        if (fundTransferBillsToReceive.size()>0) {
            System.out.println("fundTransferBillTocollect = " + fundTransferBillTocollect);
            fundTransferBillTocollect = true;
        }

        if (fundTransferBillTocollect) {
            JsfUtil.addErrorMessage("Please collect your transferred money.");
            return "";
        }
   Corrected as
        if (fundTransferBillsToReceive!=null && !fundTransferBillsToReceive.isEmpty()) {
            fundTransferBillTocollect = true;
        }

        if (fundTransferBillTocollect) {
            JsfUtil.addErrorMessage("Please collect funds transferred to you before closing.");
            return "";
        }