pawaitemadisoncollege
commented
3 years ago A few things I noticed when doing a quick preview of your project @hmkurth (including @lmjakel too):
- [ ] Only session or request should be necessary here: https://github.com/hmkurth/CommunityFoodResources/blob/556b7a45ed785539e408b2dc5e22d6ee7f1a72a0/src/main/java/com/hmkurth/controller/DeleteUser.java#L52-L53
- [ ] What about doing confirmation-y type stuff like this right in the html/jsp, almost like a validation check, rather than coming back to the server for this work?
- [ ] This bit (having the user enter the pwd twice) https://github.com/hmkurth/CommunityFoodResources/blob/556b7a45ed785539e408b2dc5e22d6ee7f1a72a0/src/main/java/com/hmkurth/controller/UserSignup.java#L38, could also be in the jsp?
- [ ] there are some printStackTraces, for example: https://github.com/hmkurth/CommunityFoodResources/blob/cff44b0878eacaff236210bc8089e814ab4d122a/src/main/java/com/hmkurth/utilities/PropertiesLoader.java#L17-L22 - the solution here may be to just throw the exception so you can catch and log it wherever the interface is implemented.
Design/Code Review 2 Project: Community Food Resources Developer: Heather Kurth Reviewer: LeeAnn Jakel
Category Criteria Comments Project Overview Which planned MVP functionality has been met? A functional list of resources in the community with good information for the user.
What planned MVP functionality has not been met? Getting the map to connect properly has not yet been successful, from what we discussed you were on a good path to getting that to work! Logging framework used, i.e., no System.out.println() or printStacktrace() statements. yes Hibernate used for all data access. yes Authentication/Authorization implemented. yes Consumes at least one web service or public api using Java. Uses a location api, google maps Application is database-driven using full CRUD. yes Database includes multiple one to many relationships. yes Deployed to AWS for public access. yes Implements best practices (for example, data validation) yes, as far as I could tell! Describe the GitHub history and what it demonstrates about the project progress during the semester. Consistent commits with descriptive explanations show that project has been in progress all semester. Describe how peer and instructor feedback/recommendations were incorporated into the project. It appears all recommendations by Paula were taken into consideration and implemented as needed. Other comments/notes Evaluate the JSPs for templating, business logic, data validation, overall look and feel. Other comments/notes? Well organized and clearly written code, good use of Lombok! Some classes seem to be missing some JavaDoc
Java code quality Evaluate the code quality for the following and identify specific areas for improvement (class, method or line number). • single-purpose methods • well-structured project • descriptive naming of packages, classes, methods, variables • classes appropriately-sized (no monster classes) • CPD (copy paste detection, meaning are the same lines of code repeated?) • are there candidates for super/subclass relationships, abstract classes, interfaces? • are any values hard-coded that should be in a properties file? • proper exception handling • proper error reporting to the user • code documentation • is there code in the servlet doGet/doPoost that should be refactored into testable classes or methods?
Unit Tests Evaluate the unit tests, for example: Yes • tests are truly a unit test rather than a high level functional test • test data is appropriately cleaned up or handled • there is full coverage of methods that perform business logic or utility functions • redundant code is eliminated by using set up and tear down methods, i.e., @before, @after
Other comments/notes? A nice start! I really like how welcoming the color scheme is and the layout of the application!