search

hmlendea / gfn-electron

Linux Desktop client for Nvidia's GeForce NOW game streaming service
GNU General Public License v3.0
510 stars 62 forks source link

Support for AppImage, deb, apk and snap #11

Closed JonathanTreffler closed 4 years ago

JonathanTreffler commented 4 years ago

This PR adds some build instruction for the electron builder.

It adds the following targets:

AppImage: For distribution with one big binary, that can be opened without installation. deb: For installing it on Debian/Ubuntu apk: For installing it on Alpine Linux Snap: For installing it on many Distributions like Ubuntu

I tested the build process and it runs great. I tested the AppImage and deb version by using them. The others should be fine.

AppImage, deb and apk should be distributed by adding them to the release files on github. The Snap needs to be uploaded to snapcraft. It should be fairly simple. Heres a tutorial.

It would probably be a good idea to add a logo, because otherwise the electron logo gets used.

closes: #9

hmlendea commented 4 years ago

I will have to look into this, and into snap, in the weekend. Thanks for the contribution!

popey commented 3 years ago

@hmlendea I work on the snap team at Canonical. I've taken the liberty of pushing your snap to the store. You can find it here: https://snapcraft.io/geforcenow - happy to hand the snap over to you, so you get to publish yourself, but also happy to publish and update on your behalf too. Up to you. Thanks to @JonathanTreffler for doing the necessary work to make the snap build.

hmlendea commented 3 years ago

Thank you both @JonathanTreffler and @popey ! Since I am not at all familiar with snap, and even as a user I still use traditional packages (for now at least) I wouldn't feel very comfortable maintaining a snap package. If it's not too much to ask @popey I think it would be best if you continue with that.

Also, as I understood, the snap is not necessary to be included in the GitHub release assets, right?

popey commented 3 years ago

@hmlendea no problem. I can continue uploading. I don't mind building it here so you don't need to host the snap in the gh releases page. What's the specific process you're using to build now? Is the readme up to date/accurate?

hmlendea commented 3 years ago

Thanks

For me there isn't an issue including the snap file in the assets. I'm just wondering if it is useful at all for regular users.

To build the release packages I simply run npm run-script build and electron-builder builds the deb, snap, zip, and apk files, which I then upload as assets to the release. So uploading the snap or not on GitHub is all the same to me. But if it's completely useless for it to be here, then I would prefer not including it for cleanness' sake.